Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few vcr marks #166

Merged
merged 1 commit into from
May 14, 2024
Merged

Add a few vcr marks #166

merged 1 commit into from
May 14, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 14, 2024

Related issues and pull requests

Description

I can't completely do away with --network-access because the download-file-size-checks don't work with pytest-vcr. cc @drnextgis

Checklist

  • Add tests
  • Add docs
  • Update CHANGELOG

@gadomski gadomski self-assigned this May 14, 2024
@gadomski gadomski force-pushed the issues/164-network-tests branch from c44a4d3 to 3c72c22 Compare May 14, 2024 18:19
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (6f7f12c) to head (3c72c22).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   80.02%   84.81%   +4.79%     
==========================================
  Files          16       16              
  Lines         981      981              
==========================================
+ Hits          785      832      +47     
+ Misses        196      149      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski merged commit a9c76c0 into main May 14, 2024
9 checks passed
@gadomski gadomski deleted the issues/164-network-tests branch May 14, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling network-touching tests
2 participants