Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attributes docs to __init__ #170

Merged
merged 1 commit into from
May 20, 2024
Merged

Move attributes docs to __init__ #170

merged 1 commit into from
May 20, 2024

Conversation

gadomski
Copy link
Member

Related issues and pull requests

Description

I didn't understand sphinx-autodoc well enough...seems better to document inside the __init__ method on assignment. cc @drnextgis. No tests or CHANGELOG needed.

Checklist

  • Add docs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 84.33%. Comparing base (827589c) to head (131b17b).

Files Patch % Lines
src/stac_asset/s3_client.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   84.97%   84.33%   -0.65%     
==========================================
  Files          16       16              
  Lines         992      983       -9     
==========================================
- Hits          843      829      -14     
- Misses        149      154       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski merged commit b31e1bb into main May 20, 2024
9 checks passed
@gadomski gadomski deleted the issues/165-attributes branch May 20, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant declaration of some properties?
2 participants