Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow content types text/xml and application/xml to be used interchangeably #173

Merged
merged 5 commits into from
May 28, 2024

Conversation

StijnCaerts
Copy link
Contributor

@StijnCaerts StijnCaerts commented May 27, 2024

Allow content types text/xml and application/xml to be used interchangeably

Related issues and pull requests

N/A

Description

The XML content types text/xml and application/xml are sometimes used interchangeably in different places. For example, the STAC metadata may reference one, but the web server for downloading may report the other one. Right now, such a scenario would cause an error when content type validation is enabled.

https://datatracker.ietf.org/doc/html/rfc2376#section-3

Checklist

  • Add tests
  • Add docs
  • Update CHANGELOG

@StijnCaerts StijnCaerts requested a review from gadomski as a code owner May 27, 2024 08:24
CHANGELOG.md Outdated Show resolved Hide resolved
tests/test_validate.py Show resolved Hide resolved
@gadomski
Copy link
Member

LGTM! Thanks for the contribution!

@gadomski gadomski enabled auto-merge (squash) May 28, 2024 13:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (e9d64b6) to head (ff2946a).

Current head ff2946a differs from pull request most recent head e43146b

Please upload reports for the commit e43146b to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files          16       16           
  Lines         991      991           
=======================================
  Hits          837      837           
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski merged commit 768d531 into stac-utils:main May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants