Expose all client attributes in config #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Removes `EarthdataClient.login` - Makes `check_content_type` a non-optional param for `HttpClient.__init__`
gadomski
force-pushed
the
issues/176-client-config
branch
from
f7b12be to
9ecc342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues and pull requests
Configfrom client attributes #176Description
After playing around with some dynamic config, I didn't like how complex it made things. Instead, I'll just make sure to bubble up all client attributes to the top-level config.
This is a breaking change that requires a MAJOR version release.
Also:
EarthdataClient.logincheck_content_typea non-optional param forHttpClient.__init__Checklist