Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom s3 endpoint #184

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Custom s3 endpoint #184

merged 7 commits into from
Jun 19, 2024

Conversation

lmizzoni
Copy link
Contributor

@lmizzoni lmizzoni commented Jun 18, 2024

Related issues and pull requests

N/A

Description

This pull request adds support for configuring a custom endpoint URL for the S3Client. This enhancement allows users to specify their own S3 endpoint.

Testing

  • Verified that S3Client connects to the specified custom endpoint URL.
  • Ensured backward compatibility by confirming the default behavior when no custom URL is provided.

Note that this feature only works if you import the functions and use it in your own code; the CLI has not been updated at this time.

Checklist

  • Add tests
  • Update CHANGELOG

@lmizzoni lmizzoni requested a review from gadomski as a code owner June 18, 2024 13:14
CHANGELOG.md Outdated Show resolved Hide resolved
src/stac_asset/config.py Outdated Show resolved Hide resolved
src/stac_asset/s3_client.py Outdated Show resolved Hide resolved
tests/test_s3_client.py Outdated Show resolved Hide resolved
@lmizzoni lmizzoni requested a review from gadomski June 19, 2024 08:08
@gadomski gadomski enabled auto-merge (squash) June 19, 2024 14:08
@gadomski gadomski merged commit 8acdc4a into stac-utils:main Jun 19, 2024
9 checks passed
@lmizzoni lmizzoni deleted the custom-s3-endpoint branch June 19, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants