Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-streaming download option #208

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

drnextgis
Copy link
Contributor

Related issues and pull requests

Fixes #202

Checklist

  • Add tests
  • Add docs
  • Update CHANGELOG

@drnextgis drnextgis requested a review from gadomski as a code owner July 28, 2024 23:26
@drnextgis drnextgis force-pushed the issues/202-no-chunking branch 2 times, most recently from d5d0da7 to 7bfcab7 Compare July 28, 2024 23:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (b675034) to head (967bf32).

Files Patch % Lines
src/stac_asset/http_client.py 0.00% 5 Missing ⚠️
src/stac_asset/s3_client.py 0.00% 5 Missing ⚠️
src/stac_asset/filesystem_client.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   85.03%   84.41%   -0.62%     
==========================================
  Files          16       16              
  Lines        1049     1059      +10     
==========================================
+ Hits          892      894       +2     
- Misses        157      165       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drnextgis drnextgis force-pushed the issues/202-no-chunking branch from 7bfcab7 to 1c85f3b Compare July 28, 2024 23:33
@drnextgis drnextgis force-pushed the issues/202-no-chunking branch from 1c85f3b to 967bf32 Compare July 28, 2024 23:38
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, it looks good to me. Pretty tricky thing to test well so I'm ok w/ just merging as-is and fixing as things come up.

@gadomski gadomski merged commit 74298df into stac-utils:main Jul 29, 2024
9 checks passed
@gadomski
Copy link
Member

Thanks @drnextgis! Released in https://github.com/stac-utils/stac-asset/releases/tag/v0.4.3

@drnextgis drnextgis deleted the issues/202-no-chunking branch July 29, 2024 14:10
@drnextgis
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add non-streaming download option to address Payload Incomplete issue
3 participants