Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert_asset_exists, assert_href_exists #85

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Aug 22, 2023

Related issues and pull requests

Description

Gives us more insight into why the existence check failed.

Checklist

  • Add tests
  • Add docs
  • Update CHANGELOG

@gadomski gadomski self-assigned this Aug 22, 2023
@gadomski gadomski force-pushed the issues/84-assert-exists branch from b1962c5 to 28dc693 Compare August 22, 2023 20:35
@gadomski gadomski enabled auto-merge (rebase) August 22, 2023 20:35
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 69.56% and project coverage change: +0.56% 🎉

Comparison is base (61be760) 78.69% compared to head (28dc693) 79.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   78.69%   79.25%   +0.56%     
==========================================
  Files          15       15              
  Lines         859      863       +4     
==========================================
+ Hits          676      684       +8     
+ Misses        183      179       -4     
Files Changed Coverage Δ
src/stac_asset/__init__.py 100.00% <ø> (ø)
src/stac_asset/http_client.py 55.81% <33.33%> (+3.64%) ⬆️
src/stac_asset/planetary_computer_client.py 42.10% <50.00%> (ø)
src/stac_asset/s3_client.py 52.30% <50.00%> (+3.03%) ⬆️
src/stac_asset/client.py 79.34% <60.00%> (-1.77%) ⬇️
src/stac_asset/filesystem_client.py 92.00% <66.66%> (-3.46%) ⬇️
src/stac_asset/_functions.py 90.30% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski merged commit e2b8415 into main Aug 22, 2023
@gadomski gadomski deleted the issues/84-assert-exists branch August 22, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add assert_*_exists functions/methods
2 participants