Add blocking interface #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
issues/82-blocking
branch
from
7370640 to
bc34c28
Compare
gadomski
force-pushed
the
issues/82-blocking
branch
from
bc34c28 to
f51e10c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 79.25% 80.00% +0.74%
==========================================
Files 15 16 +1
Lines 863 885 +22
==========================================
+ Hits 684 708 +24
+ Misses 179 177 -2
☔ View full report in Codecov by Sentry. |
ircwaves
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues and pull requests
Description
It'll be a slight pain to keep the blocking interface up-to-date with the non-blocking, but that's what we have to do I guess.
Checklist