Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a released version of jsonschema #105

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

gadomski
Copy link
Member

I think this is causing us to pick up an alpha version of jsonschema in downstreams, which is causing hard-to-track down breakages.

IMO, released versions of packages should depend on released versions of other packages when at all possible.

If possible, it'd be great to get a release (BUGFIX or otherwise) of stac-check after this is merged, so downstreams can pick up the dependency fix.

Context

I _think_ this is causing us to pick up an alpha version of jsonschema in
downstreams, which is causing hard-to-track down breakages.

IMO, released versions of packages should depend on released versions of other
packages when at all possible.
@gadomski gadomski requested a review from jonhealy1 March 22, 2023 16:55
@gadomski gadomski self-assigned this Mar 22, 2023
@gadomski gadomski requested a review from pjhartzell March 23, 2023 11:29
@gadomski gadomski mentioned this pull request Mar 23, 2023
5 tasks
Copy link

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this change, but will defer to @jonhealy1 for approval.

@jonhealy1 jonhealy1 merged commit 9f5387c into main Mar 23, 2023
@gadomski gadomski deleted the use-stable-jsonschema branch March 23, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants