Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split development dependencies from runtime dependencies #109

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

jkeifer
Copy link
Member

@jkeifer jkeifer commented Nov 7, 2023

I was noticing that pytest was getting pulled in to a project's runtime dependencies per it's dependency on this package. Looking more closely at the code, it appears types-setuptools and pytest are not actual runtime dependencies of this package but development-only dependencies.

This PR is to split those two packages into a extra requirements set called dev so they aren't part of the runtime dependency set for this package.

Now, for local development, instead of running pip install -e ., one would run pip install -e '.[dev]'.

@jkeifer
Copy link
Member Author

jkeifer commented Nov 7, 2023

The tests are failing, but that looks to be a pre-existing issue I'm not sure how to address at the moment.

@jonhealy1
Copy link
Collaborator

The tests are failing, but that looks to be a pre-existing issue I'm not sure how to address at the moment.

This looks great. I will try to figure out the tests situation. Thanks

setup.py Outdated Show resolved Hide resolved
jonhealy1 and others added 2 commits November 17, 2023 17:54
Co-authored-by: Phil Varner <pvarner@element84.com>
Co-authored-by: Phil Varner <pvarner@element84.com>
@jonhealy1 jonhealy1 merged commit d75c105 into stac-utils:main Nov 17, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants