Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.4.11 #68

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Release v2.4.11 #68

merged 3 commits into from
Dec 12, 2023

Conversation

edkeeble
Copy link
Contributor

@edkeeble edkeeble commented Dec 1, 2023

Description:

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@gadomski
Copy link
Member

gadomski commented Dec 7, 2023

Sorry for the delay on this @edkeeble, tests are currently failing locally for me on main (and in other simple PRs, e.g. #69) so I'd like to sort that out before cutting a release.

@edkeeble
Copy link
Contributor Author

edkeeble commented Dec 7, 2023

@gadomski no problem. That's curious. Tests are still passing locally for me on main. Happy to help debug, if it's useful.

Somewhat related, but probably not the source of the problem: it appears we're running the test suite once for each of python 3.8, 3.9, 3.10 and 3.11, but those versions are only applied on the host platform. The tests still run in docker and the image is built on python:3.8-slim, so we may actually be testing 3.8 four times. This is evidenced by the github action logs for the failing tests, which list the following prior to test runs on 3.10 and 3.11:

platform linux -- Python 3.8.18, pytest-7.4.3, pluggy-1.3.0 -- /usr/local/bin/python

@edkeeble
Copy link
Contributor Author

@gadomski Looks like the issue is in a recent release of pytest-asyncio. There's a prerelease version (0.23.3) up to resolve the bug: https://pytest-asyncio.readthedocs.io/en/latest/reference/changelog.html#unreleased

@gadomski gadomski enabled auto-merge (squash) December 12, 2023 22:36
@gadomski gadomski disabled auto-merge December 12, 2023 22:36
@gadomski gadomski enabled auto-merge (squash) December 12, 2023 22:48
@gadomski gadomski merged commit c4d8453 into stac-utils:main Dec 12, 2023
6 checks passed
@gadomski
Copy link
Member

Thanks for the PR and your patience, @edkeeble. Looks like the PyPI publish failed: https://github.com/stac-utils/stac-fastapi-pgstac/actions/runs/7188583458/job/19578503637. I haven't dug into it yet, but it could be because the PyPI password has expired for the stac-utils org (just a guess)? I'll check tomorrow.

@gadomski
Copy link
Member

Ok, we've got the permissions figured out, release published: https://pypi.org/project/stac-fastapi.pgstac/2.4.11/. Thanks for your patience @edkeeble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants