Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong CQL Text/JSON conformance classes #539

Closed
m-mohr opened this issue Mar 7, 2023 · 4 comments · Fixed by #540
Closed

Wrong CQL Text/JSON conformance classes #539

m-mohr opened this issue Mar 7, 2023 · 4 comments · Fixed by #540
Assignees
Labels
bug Something isn't working spec Compliance with STAC/OGC specifications

Comments

@m-mohr
Copy link
Contributor

m-mohr commented Mar 7, 2023

I think the CQL Text/JSON conformance classes are not correct. I haven't checked the implementation myself, just base my knowledge on the MS PC API deployment and the docs: https://stac-utils.github.io/stac-fastapi/api/stac_fastapi/extensions/core/filter/filter/#filterextension

  • MSPC and docs: https://api.stacspec.org/v1.0.0-rc.1/item-search#filter:cql-text and json equivalent
  • The Filter extension indicates: http://www.opengis.net/spec/cql2/1.0/conf/cql2-text and json equivalent

Originally posted by @m-mohr in #371 (comment)

@gadomski
Copy link
Member

gadomski commented Mar 7, 2023

@philvarner I believe @m-mohr is correct, stac-fastapi is doing it wrong, but if you don't mind can you double-check? E.g. I get this against the pgstac backend on current main (6db83a9):

$ curl -s http://localhost:8080/conformance | jq | grep cql-text
    "https://api.stacspec.org/v1.0.0-rc.1/item-search#filter:cql-text",

@gadomski gadomski added bug Something isn't working spec Compliance with STAC/OGC specifications labels Mar 7, 2023
@gadomski
Copy link
Member

gadomski commented Mar 8, 2023

Once complicating factor, @m-mohr, is that http://www.opengis.net/spec/cql2/1.0/conf/cql2-text is a 404. So the spec itself seems to be wrong (or at least has broken dependencies). @philvarner can you advise?

@m-mohr
Copy link
Contributor Author

m-mohr commented Mar 8, 2023

OGC URIs often don't resolve, that's normal, I think. @gadomski
Same applies for example for http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/oas30 and http://www.opengis.net/spec/ogcapi-features-3/1.0/conf/filter, which are used already.

@gadomski
Copy link
Member

gadomski commented Mar 8, 2023

That's very weird, but OK, thanks.

@gadomski gadomski self-assigned this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spec Compliance with STAC/OGC specifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants