Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance classes inconsistency #371

Closed
m-mohr opened this issue Mar 5, 2022 · 5 comments
Closed

Conformance classes inconsistency #371

m-mohr opened this issue Mar 5, 2022 · 5 comments
Assignees
Labels
api layer bug Something isn't working spec Compliance with STAC/OGC specifications
Milestone

Comments

@m-mohr
Copy link
Contributor

m-mohr commented Mar 5, 2022

Some conformance classes have a trailing slash (sometimes before a fragment) and sometimes not.
For example sort is https://api.stacspec.org/v1.0.0-beta.4/item-search/#sort although it seems from the spec that it should be https://api.stacspec.org/v1.0.0-beta.4/item-search#sort

@m-mohr m-mohr added the bug Something isn't working label Mar 5, 2022
@philvarner philvarner added the spec Compliance with STAC/OGC specifications label Mar 24, 2022
@philvarner philvarner self-assigned this Mar 25, 2022
@m-mohr
Copy link
Contributor Author

m-mohr commented Jun 28, 2022

There seem to be a couple more things inconsistent: #417

@geospatial-jeff
Copy link
Collaborator

I think this may have been fixed but I'd like to do one more pass through all of the conformance classes after #432 is finished.

@gadomski gadomski assigned gadomski and unassigned philvarner Jan 31, 2023
@gadomski gadomski added this to the 2.4.4 milestone Jan 31, 2023
@gadomski
Copy link
Member

gadomski commented Mar 7, 2023

I checked both backends locally and they look fine. I'm going to close this a fixed pre-2.4.4, please reopen if there's incorrect conformance classes found.

@gadomski gadomski closed this as completed Mar 7, 2023
@m-mohr
Copy link
Contributor Author

m-mohr commented Mar 7, 2023

@gadomski Looks better now, but I just found that at least MSPC still uses strange CQL Text/JSON conformance classes.
Not sure whether that's a MS PC or a STAC Fastapi bug though as I don't use STAC Fastapi myself.

  • MSPC: https://api.stacspec.org/v1.0.0-rc.1/item-search#filter:cql-text and json equivalent
  • The Filter extension indicates: http://www.opengis.net/spec/cql2/1.0/conf/cql2-text and json equivalent

Edit: But it seems the wrong (old?) ones are listed here as well: https://stac-utils.github.io/stac-fastapi/api/stac_fastapi/extensions/core/filter/filter/#filterextension

Edit 2: Opened #539

@gadomski
Copy link
Member

gadomski commented Mar 7, 2023

Yup, I think you're right but will ask Phil to check to make sure (over on the new issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api layer bug Something isn't working spec Compliance with STAC/OGC specifications
Projects
None yet
Development

No branches or pull requests

4 participants