Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFERRED_LINK_RELS is missing items links? #634

Closed
guidorice opened this issue Feb 15, 2024 · 1 comment
Closed

INFERRED_LINK_RELS is missing items links? #634

guidorice opened this issue Feb 15, 2024 · 1 comment

Comments

@guidorice
Copy link

In stac-fastapi (latest) with pgstac backend we noticed in our stac catalog that collection.links were getting lots of "rel":"items" stored, which was causing problems with API consumers- because incorrect or duplicated items links were being returned by the API.

Here is where the inferred link rels are defined:
https://github.com/stac-utils/stac-fastapi-pgstac/blob/a1b06331d5882b682c7471fbe330c1e0d18586cb/stac_fastapi/pgstac/models/links.py#L14
and note also that the items are actually dynamically constructed over here:
https://github.com/stac-utils/stac-fastapi-pgstac/blob/a1b06331d5882b682c7471fbe330c1e0d18586cb/stac_fastapi/pgstac/models/links.py#L199-L205

The fix could be as simple as adding items to that list constant, but also noting that this fix might involve touching these 3 repos:
https://github.com/search?q=org%3Astac-utils%20INFERRED_LINK_RELS&type=code

Related issue: #505

cc @geospatial-jeff @duckontheweb

StijnCaerts added a commit to StijnCaerts/stac-fastapi that referenced this issue Mar 13, 2024
vincentsarago added a commit to StijnCaerts/stac-fastapi that referenced this issue Apr 9, 2024
vincentsarago added a commit that referenced this issue Apr 9, 2024
Co-authored-by: Vincent Sarago <vincent.sarago@gmail.com>
@vincentsarago
Copy link
Member

this was resolved by #640 and will be published in next stac-fastapi version

Note: Backend repo will need to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants