Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply necessary environment variables for example docker-compose #313

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

moradology
Copy link
Collaborator

@moradology moradology commented Jan 4, 2022

Description:
After the inclusion of pgstac 0.4.0, the example compose file was not working appropriately. Apparently, some environment variables now expected were not added (woops). This corrects that oversight

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@zstatmanweil
Copy link
Contributor

Thanks for catching this, @moradology - could not figure out what was going on. It is working for me now too if that helps the reviewer!

@zstatmanweil
Copy link
Contributor

zstatmanweil commented Jan 7, 2022

Actually @moradology , I may have spoke too soon! The joplin data wasn't loaded for me in the pgstac backen when I ran docker-compose build and then docker-compose up and I believe last time I ran it locally I didn't have to do anything special to get the data loaded. Perhaps I am misremembering though. Did the joplin data load for you? I added the same environment variables to loadjoplin-pgstac in the docker-compose file but that didn't solve the issue.

@moradology
Copy link
Collaborator Author

Verifying right now, but it appears as though data loaded correctly for me. Might be a matter of blowing away container state first? I (this is overkill) like to docker system prune -a when in doubt

@zstatmanweil
Copy link
Contributor

You are exactly right! It is working for me now. Sorry for the false alarm

@moradology
Copy link
Collaborator Author

No sweat. My propensity to set of false alarms is exactly why I blow away everything: you are definitely not alone

@moradology moradology merged commit 2f8e96b into stac-utils:master Jan 7, 2022
@moradology moradology deleted the fix/pgstac-env-vars branch January 7, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants