Add support for APIRouter prefix #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drnextgis
force-pushed
the
router_prefix
branch
5 times, most recently
from
0b89b2e to
bd9253d
Compare
|
|
||
| resp = await app_client.get(link_path) | ||
| resp = await app_client.get(link_path.rsplit("/", 1)[-1]) |
There was a problem hiding this comment.
Can you explain why this is necessary?
There was a problem hiding this comment.
app_client is configured with base_url which already includes router prefix.
captaincoordinates
approved these changes
Jul 25, 2022
|
Will get this merged because it does solve the immediate problem (thanks for throwing together that repo) but I do think we want to circle back and be more consistent with how APIRouters are used and how |
geospatial-jeff
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Add support for APIRouter prefix (pgstac backend only).
PR Checklist:
pre-commit run --all-files)make test)make docs)