Bumpallowedpygeofilter #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for getting this merged. We had to pin |
This was referenced Nov 16, 2022
|
Never mind, I see now that there is no v0.3. It's a larger discussion, but I'm generally against top bounds on dependencies for library packages like this one -- instead, I like to rely on CI to catch breakages caused by upstream version bumps. For more detail, a post. I'll implement @vincentsarago's suggestion to floor at v0.2 (it's nice to remove a transitive dependency that isn't directly imported) then re-request review to get this moving. |
|
Added a manual cherry-pick of a7f5c75 to ceil fastapi #irony |
geospatial-jeff
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump allowed version of pygeofilter to include 0.2.*.