Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support intersects for GET requests #521

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 2, 2023

Related Issue(s):

Description:

Adds support to both backends, and includes tests. Removes the converter for the BaseSearchGetRequest to not convert it to a list -- it should be a url-encoded dict.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@gadomski gadomski added this to the 2.4.4 milestone Feb 2, 2023
@gadomski gadomski requested a review from philvarner February 2, 2023 16:58
@gadomski gadomski self-assigned this Feb 2, 2023
Copy link
Collaborator

@geospatial-jeff geospatial-jeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gadomski gadomski merged commit 955c34e into master Feb 7, 2023
@gadomski gadomski deleted the issues/468-get-intersects branch February 7, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET /search ignores intersects parameter
2 participants