Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding queryables link to landing page #587

Merged
merged 9 commits into from
Apr 10, 2024
Merged

Adding queryables link to landing page #587

merged 9 commits into from
Apr 10, 2024

Conversation

constantinius
Copy link
Contributor

@constantinius constantinius commented Jul 6, 2023 •
edited
Loading

Related Issue(s):

Description:

Adds the /queryables link to the landing page

Requires stac-utils/stac-pydantic#123

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@constantinius constantinius marked this pull request as ready for review July 6, 2023 09:55
@m-mohr m-mohr mentioned this pull request Mar 14, 2024
Merged
4 tasks
@vincentsarago vincentsarago requested a review from jonhealy1 April 10, 2024 08:05
@vincentsarago vincentsarago added this to the 2.5.0 milestone Apr 10, 2024
@vincentsarago
Copy link
Member

@jonhealy1 This is the only PR which needs to be merged before 2.5 release!

jonhealy1
jonhealy1 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentsarago vincentsarago merged commit a262115 into stac-utils:main Apr 10, 2024
7 checks passed
@m-mohr
Copy link
Contributor

m-mohr commented Apr 10, 2024

Didn't this PR require stac-utils/stac-pydantic#123, which is still open?

@vincentsarago
Copy link
Member

😬 because this PR wasn't marked as Draft I didn't know it was dependent to another PR in stac-pydantic 😓

@vincentsarago vincentsarago mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago left review comments

@m-mohr m-mohr m-mohr left review comments

@gadomski gadomski gadomski left review comments

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@constantinius @vincentsarago @m-mohr @gadomski @jonhealy1