Add an option for a browser link column #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stac_geoparquet/stac_geoparquet.py
Outdated
| @@ -43,6 +46,8 @@ def to_geodataframe( | |||
| ---------- | |||
| items: A sequence of STAC items. | |||
| add_self_link: Add the absolute link (if available) to the source STAC Item as a separate column named "self_link" | |||
| add_browser_link: Add an absolute link to an alternate HTML representation of the source STAC Item (if available) | |||
There was a problem hiding this comment.
I think that this should explicitly document the conditions for this link being exracted:
- The relation type must be
alternate - The media type must be
text/html - The href must be absolute (or whatever we're checking for. Fully qualified domain name?)
stac_geoparquet/stac_geoparquet.py
Outdated
| @@ -43,6 +46,8 @@ def to_geodataframe( | |||
| ---------- | |||
| items: A sequence of STAC items. | |||
| add_self_link: Add the absolute link (if available) to the source STAC Item as a separate column named "self_link" | |||
| add_browser_link: Add an absolute link to an alternate HTML representation of the source STAC Item (if available) | |||
| as a separate column named "browser_link" | |||
There was a problem hiding this comment.
I think sphinx wants subsequent lines indented a bit. Maybe 3 spaces.
There was a problem hiding this comment.
Added 3 spaces (but I'm not sure it has the intended effect?!).
m-mohr
force-pushed
the
add-alternate-link
branch
from
d16af45
to
92a09cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option that looks for an alternate link with the HTML media type and adds a separate column
browser_linkwith the link to the HTML representation. This is pretty much aligned with the self link option and works more generally than the proposal from @cholmes in #15 that was specific to STAC Browser.