refactor: make Pgstac a trait (#551)

We were using it like a trait anyways, and I think this will make
downstream usage much easier. cc @bitner

crates/core/src/lib.rs

@@ -144,8 +144,7 @@
     unused_import_braces,
     unused_lifetimes,
     unused_qualifications,
-    unused_results,
-    warnings
+    unused_results
 )]
 
 mod asset;

crates/pgstac/CHANGELOG.md

@@ -6,10 +6,18 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+### Added
+
+- `Pgstac` trait ([#551](https://github.com/stac-utils/stac-rs/pull/551))
+
 ### Changed
 
 - Return JSON, not STAC ([#550](https://github.com/stac-utils/stac-rs/pull/550))
 
+### Removed
+
+- `Client` ([#551](https://github.com/stac-utils/stac-rs/pull/551))
+
 ## [0.2.2] - 2024-11-12
 
 Bump dependencies.

crates/pgstac/Cargo.toml

@@ -15,19 +15,18 @@ rust-version.workspace = true
 tls = ["dep:rustls", "dep:tokio-postgres-rustls", "dep:webpki-roots"]
 
 [dependencies]
-geojson.workspace = true
 rustls = { workspace = true, features = ["ring", "std"], optional = true }
 serde.workspace = true
 serde_json.workspace = true
-stac.workspace = true
 stac-api.workspace = true
 thiserror.workspace = true
 tokio-postgres = { workspace = true, features = ["with-serde_json-1"] }
 tokio-postgres-rustls = { workspace = true, optional = true }
-tracing.workspace = true
 webpki-roots = { workspace = true, optional = true }
 
 [dev-dependencies]
+geojson.workspace = true
+stac.workspace = true
 pgstac-test = { path = "pgstac-test" }
 tokio = { workspace = true, features = ["rt-multi-thread", "macros"] }
 tokio-test.workspace = true

crates/pgstac/pgstac-test/src/lib.rs

@@ -21,9 +21,8 @@ fn impl_pgstac_test(ast: ItemFn) -> TokenStream {
                 connection.await.unwrap()
             });
             let transaction = client.transaction().await.unwrap();
-            let client = Client::new(&transaction);
             #ast
-            #ident(&client).await;
+            #ident(&transaction).await;
             transaction.rollback().await.unwrap();
         }
     };