-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Fields impl for Link #542
Conversation
c21abf9
to
b0c429b
Compare
Disclaimer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the contribution! As of #507, I think we could just #[derive(Fields)]
on the Links
structure, rather than manually implementing it. See
stac-rs/crates/core/src/collection.rs
Line 25 in 533a8b3
#[derive(Debug, Serialize, Deserialize, PartialEq, Clone, SelfHref, Links, Fields)] |
The code is ready. I am a bit lost with the Currently, the change is reflected in the |
Yeah, |
Closes
Description
Add implementation of
Field
trait forLink
.Checklist
Delete any checklist items that do not apply (e.g. if your change is minor, it may not require documentation updates).
cargo fmt
)cargo test