-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Use pydantic #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
rewrite
branch
5 times, most recently
from
September 18, 2023 23:05
d29404c
to
87bf2f0
Compare
Open
Includes: - pydantic under the hood - move handler out of task into payload - STAC models
See, this is why you never write docs!
Closing as OBE. Maybe we'll re-visit someday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a total rewrite of the library to use pydantic under the hood for validation and input/output schema generation. Key points:
Task
are provided for common use-casesTask
process(self, input: List[Any]) -> List[Any]
StacOutTask
process_to_items(self, input: List[Any]) -> List[Item]
StacInStacOutTask
process_items(self, input: List[Item]) -> List[Item]
OneToManyTask
process_one_to_many(self, input: Any) -> List[Any]
OneToOneTask
process_one_to_one(self, input: Any) -> Any
ToItemTask
process_to_item(self, input: Any) -> Item
ItemTask
process_item(self, item: Item) -> Item
HrefTask
process_href(self, href: str) -> Item
Payload
and its substructures. This will hopefully solidify the data model for payloads (there had been confusion in the past around dict-or-list for process, etc)Payload
, so tasks just worry about themselvesexamples/
directory for more information.stac-task list
for showing available tasks, andstac-task jsonschema TASK MODEL
for dumping the jsonschemastac_task
(fromstactask
) -- I figure this is a good chance to bring the naming in line with other repos AND clearly signal these very breaking changes to downstreamsOpening as a draft PR for visibility and feedback.
Task list