Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure whether to open URLs when validating assets #238

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

vprivat-ads
Copy link
Contributor

@vprivat-ads vprivat-ads commented Nov 29, 2024

I would like to validate assets without actually opening their href URLs.

@jonhealy1
Copy link
Collaborator

Hi @vprivat-ads. This looks really good. I think a changelog entry, a test, and updating the CLI section in the Readme would be a good idea too. Thank you.

@vprivat-ads
Copy link
Contributor Author

Ok, thank you :)

@vprivat-ads vprivat-ads marked this pull request as draft December 2, 2024 17:09
@vprivat-ads vprivat-ads force-pushed the optional-link-href-urlopen branch from 06ab639 to aa8a0b9 Compare December 12, 2024 10:33
@vprivat-ads vprivat-ads force-pushed the optional-link-href-urlopen branch from aa8a0b9 to 6422e57 Compare December 12, 2024 10:37
@vprivat-ads vprivat-ads marked this pull request as ready for review December 12, 2024 10:37
@vprivat-ads
Copy link
Contributor Author

Hi @jonhealy1 I think it's ok now :)

@jonhealy1 jonhealy1 self-requested a review December 13, 2024 08:24
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here. Thank you!

@jonhealy1 jonhealy1 merged commit 492547b into stac-utils:main Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants