Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate stac-check #230

Closed
gadomski opened this issue Feb 14, 2022 · 2 comments · Fixed by #254
Closed

Incorporate stac-check #230

gadomski opened this issue Feb 14, 2022 · 2 comments · Fixed by #254
Labels
enhancement New feature or request
Milestone

Comments

@gadomski
Copy link
Member

Is your feature request related to a problem? Please describe.
We've had halting support for using upstream validators as a part of the stactools cli, e.g. #191 and #151. There's probably space for taking a step back and making the stac validate story a bit more coherent, but as an incremental improvement we could include the new https://github.com/jonhealy1/stac-check project.

Describe the solution you'd like
Add a stac lint command, e.g.:

stac lint simple-item.json

This could include a --recursive option to lint an entire tree.

Describe alternatives you've considered
There could(/should) be a higher-level stac validate command that includes linting. There's also some common "take this STAC catalog and report on it" architecture common between stac info, stac validate, and ??? that could be refactored.

Additional context
None

@gadomski gadomski added the enhancement New feature or request label Feb 14, 2022
@jonhealy1
Copy link
Contributor

jonhealy1 commented Mar 2, 2022

Hi. I have made a draft pr. I have added a lint option to the cli. I have also added the basic STAC best practices warning messages from https://github.com/jonhealy1/stac-check. I could add some of the validation messaging I use too if wanted, which mostly comes from the stac-validator project: https://github.com/sparkgeo/stac-validator

@gadomski gadomski linked a pull request Mar 2, 2022 that will close this issue
5 tasks
@gadomski
Copy link
Member Author

gadomski commented Mar 2, 2022

This is great! I dropped an initial review on #254 with a couple of notes.

Since stac-check will bring in stac-validator as a dependency, I think it will make sense to switch the stactools validation command to use stac-validator. That doesn't have to happen in #254, I'm happy to do it myself in a follow-on PR.

Thanks again for the contribution, stac-check looks like a great tool!

@gadomski gadomski added this to the v0.3.0 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants