Incorporate stac-check linting tool

[jonhealy1]

Before you submit a pull request, please fill in the following:

Related Issue(s):
#230

Description:

• Added a lint option to the cli
• Imported basic STAC best practice messages from https://github.com/jonhealy1/stac-check

PR checklist:

• Code is formatted (run scripts/format).
• Code lints properly (run scripts/lint).
• Tests pass (run scripts/test).
• Documentation has been updated to reflect changes, if applicable.
• Changes are added to the CHANGELOG.

[gadomski]

This looks great, only issue now is that the the test with "data-files/linting/20201211_223832_cs2.json" fails. Looks like that item is missing a self link:

$ stac lint tests/data-files/linting/20201211_223832_cs2.json
WARNING A link to 'self' in links is strongly recommended

[gadomski]

Ah thanks, I might have had an old version of stac-check installed, so that was probably my mistake.

I'm do think I'm going to open an issue on stac-check re: self links -- though it says they're strongly recommended in the spec documents themselves, the best practices have many cases where they say a self link should only be used in one spot (for relative published catalogs) or never (for self-contained catalogs). I think it's an issue w/ the spec too.

[jonhealy1]

Ah thanks, I might have had an old version of stac-check installed, so that was probably my mistake.

I'm do think I'm going to open an issue on stac-check re: self links -- though it says they're strongly recommended in the spec documents themselves, the best practices have many cases where they say a self link should only be used in one spot (for relative published catalogs) or never (for self-contained catalogs). I think it's an issue w/ the spec too.

Ok awesome for sure.