Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak to adapt to USGS changes #109

Merged
merged 8 commits into from
May 11, 2021
Merged

Tweak to adapt to USGS changes #109

merged 8 commits into from
May 11, 2021

Conversation

carioca-au
Copy link
Contributor

  • Tweaked to adapt to USGS changes
    • tested property name eo:off_nadir, view:off_nadir
    • Tested eo:instrument data type
    • removed unused "name" variable
  • Re-indented code item.ext.projection.set_transform and item.ext.projection.set_shape

@carioca-au
- Tweaked to adapt to USGS changes
85a88b5 
  - tested property name eo:off_nadir, view:off_nadir
  - Tested eo:instrument data type
  - removed unused "name" variable
@carioca-au carioca-au mentioned this pull request May 11, 2021
Closed
carioca-au added 5 commits May 11, 2021 12:26
@carioca-au
- Tweaked to adapt to USGS changes
017833a 
  - tested property name eo:off_nadir, view:off_nadir
  - Tested eo:instrument data type
  - removed unused "name" variable
- Re-indented code item.ext.projection.set_transform and item.ext.projection.set_shape
@carioca-au
- Tweaked to adapt to USGS changes
4ace96f 
  - tested property name eo:off_nadir, view:off_nadir
  - Tested eo:instrument data type
  - removed unused "name" variable
- Re-indented code item.ext.projection.set_transform and item.ext.projection.set_shape
@carioca-au
- Fixing test_transform_static_stac_missing_asset_b2_b10
95b2ce3
@carioca-au
- Fixing test_transform_static_stac_missing_asset_b2_b10
ce0b245
@carioca-au
- Fixing test_transform_static_stac_missing_asset_b2_b10
b5e71cf
@gadomski gadomski added this to the v0.1.6 milestone May 11, 2021
@gadomski gadomski linked an issue May 11, 2021 that may be closed by this pull request
Tweaked to adapt to USGS changes #110
Closed
@gadomski gadomski self-requested a review May 11, 2021 12:13
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021 •
edited
Loading

Codecov Report

Merging #109 (af251d7) into master (a4aa9b4) will decrease coverage by 0.24%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   85.31%   85.07%   -0.25%     
==========================================
  Files          81       81              
  Lines        2417     2425       +8     
==========================================
+ Hits         2062     2063       +1     
- Misses        355      362       +7
Impacted Files Coverage Δ
stactools_landsat/stactools/landsat/utils.py 88.31% <53.33%> (-8.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4aa9b4...af251d7. Read the comment docs.

gadomski
gadomski requested changes May 11, 2021
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but there's seven commits here but it looks like a lot of them are duplicates. Can you clean up the history and force-push one or two commits for this PR?

tests/landsat/test_commands.py Outdated Show resolved Hide resolved
carioca-au
carioca-au commented May 11, 2021
View reviewed changes
Copy link
Contributor Author

@carioca-au carioca-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything done

@gadomski gadomski merged commit 79315a1 into stac-utils:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.6
Development

Successfully merging this pull request may close these issues.

Tweaked to adapt to USGS changes
3 participants
@carioca-au @codecov-commenter @gadomski