Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip relative path prefix from Sentinel 2 assets. #125

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

lossyrob
Copy link
Member

@lossyrob lossyrob commented Jun 8, 2021

This commit removes a '/./' that was contained in some asset hrefs for Sentinel 2 L2A items, which was caused by paths being read with a ./ prefix and joined to the base href.

This commit removes a '/./' that was contained in some asset
hrefs for Sentinel 2 L2A items, which was caused by paths being read
with a ./ prefix and joined to the base href.
@lossyrob lossyrob requested a review from gadomski June 8, 2021 22:38
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #125 (87c8946) into master (7e67bce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          82       82           
  Lines        2463     2464    +1     
=======================================
+ Hits         2100     2101    +1     
  Misses        363      363           
Impacted Files Coverage Δ
...ols_sentinel2/stactools/sentinel2/safe_manifest.py 95.45% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e67bce...87c8946. Read the comment docs.

@gadomski gadomski added this to the v0.1.6 milestone Jun 9, 2021
@gadomski gadomski merged commit 6070940 into master Jun 9, 2021
@gadomski gadomski deleted the fix/rde/sentinel2-assets branch June 9, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants