-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'add' command to add an item to a catalog/collection #153
Conversation
@volaya checking in on this PR, is this WIP or is it ready for review? |
@gadomski I added new tests and this should be ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests! I have one change requested in the unit tests (checking to make sure the item was added to the correct collection), and then a couple musing thoughts that aren't really change requests, just questions. Once the test change is made and CI is passing this looks good to go!
CI is failing, but it seems to fail in something not related to this PR. |
I've got a fix queued up in #198. |
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Also add changelog entry for #153
Also add changelog entry for #153
[WIP] The functionality is there, but the PR is missing a better collection of tests to test all options. I will work on adding them ASAP
This PR fixes #148