Remove GDAL's Python bindings #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
added a commit
that referenced
this pull request
Jan 19, 2022
gadomski
added a commit
that referenced
this pull request
Jan 19, 2022
gadomski
force-pushed
the
issues/216-remove-gdal
branch
from
8d3005d to
7ed4f7c
Compare
This changes the API of the cogify function.
This helps debug dict differences better.
This requires refactoring `add_raster_to_item` to use rasterio instead of GDAL bindings. During this refactor, I discovered that the original implementation was not correctly handling the top bound of the histogram calculation, and so the last bin value was one too low in the tests. The test case was corrected.
gadomski
force-pushed
the
issues/216-remove-gdal
branch
from
7ed4f7c to
988c691
Compare
sgillies
reviewed
Jan 19, 2022
|
@gadomski I think the cogify function could be removed and left to rio-cogeo or gdal_translate, but this PR is fine. Rasterio's copy function calls GDALCreateCopy and thus should be a pretty complete COG maker. |
duckontheweb
approved these changes
Jan 20, 2022
This was referenced Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #216, #217
Description: To simplify our dependency tree, this PR removes direct use of the GDAL Python bindings (used in the
addrastercommand). This represents a breaking change because it changes the function signature ofcogify.Additional fix:
cogifyto use rasterio instead of a system call togdal_translate. This is instead of Remove cogify #217 (and Remove cogify #217 should be closed if this PR is merged).cc @sgillies
Closes #216
Closes #217
PR checklist:
scripts/format).scripts/lint).scripts/test).