Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't push images from PRs #225

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Don't push images from PRs #225

merged 3 commits into from
Feb 3, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 2, 2022

Related Issue(s): #200, #203

Description: Don't push Docker images from pull requests.

Includes some linting on the Github actions yml files.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Changes are added to the CHANGELOG.

Fixes #203
Helps #200 (need to manually delete images)
@gadomski gadomski force-pushed the issues/203-ci-docker-images branch from 8ddf658 to a9f75ad Compare February 2, 2022 21:53
@gadomski
Copy link
Member Author

gadomski commented Feb 2, 2022

I don't know a great way to prove that it didn't push an image, but here's a screenshot of https://github.com/stac-utils/stactools/pkgs/container/stactools from right after CI completed:

Screenshot 2022-02-02 at 15-04-20 Build software better, together

@gadomski gadomski linked an issue Feb 2, 2022 that may be closed by this pull request
Copy link

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I can't think of a good way to test that it's not pushing those images either. I think just manually verifying it a few times after this has been merged should be sufficient.

@gadomski gadomski merged commit 4a19089 into main Feb 3, 2022
@gadomski gadomski deleted the issues/203-ci-docker-images branch February 3, 2022 20:03
gadomski added a commit that referenced this pull request Feb 3, 2022
The previous attempt (#225) didn't work, so hopefully this one will.
gadomski added a commit that referenced this pull request Feb 14, 2022
The previous attempt (#225) didn't work, so hopefully this one will.
gadomski added a commit that referenced this pull request Feb 14, 2022
The previous attempt (#225) didn't work, so hopefully this one will.
@gadomski gadomski mentioned this pull request Feb 15, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop the CI from pushing images for PRs
2 participants