Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stac-validator for validation #289

Merged
merged 3 commits into from
May 5, 2022
Merged

Use stac-validator for validation #289

merged 3 commits into from
May 5, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 3, 2022 •
edited
Loading

Related Issue(s):

Description:
Switches from using custom validation code to https://github.com/stac-utils/stac-validator. Draft until stac-validator v3.1.0 is released.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@gadomski gadomski added this to the v0.3.1 milestone May 3, 2022
@gadomski gadomski force-pushed the issues/255-stac-validator branch from 25f8ba9 to 1e231bd Compare May 4, 2022 16:08
@gadomski gadomski marked this pull request as ready for review May 4, 2022 16:08
@gadomski gadomski requested a review from philvarner May 4, 2022 16:08
philvarner
philvarner requested changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@philvarner philvarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@philvarner
Copy link
Collaborator

except for failures, LGTM

@gadomski gadomski force-pushed the issues/255-stac-validator branch from 7f032d6 to fc071e0 Compare May 5, 2022 16:21
@gadomski gadomski requested a review from philvarner May 5, 2022 16:27
@gadomski gadomski merged commit 3055742 into main May 5, 2022
@gadomski gadomski deleted the issues/255-stac-validator branch May 5, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philvarner philvarner philvarner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging this pull request may close these issues.

Use stac-validator for our validation function
2 participants
@gadomski @philvarner