Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added geometry.py #314

Merged
merged 8 commits into from
Jun 22, 2022
Merged

Added geometry.py #314

merged 8 commits into from
Jun 22, 2022

Conversation

geomatician
Copy link
Contributor

@geomatician geomatician commented Jun 13, 2022

Before you submit a pull request, please fill in the following:

Related Issue(s):
#184

Description:
Added geometry.py to Core to generate a bounding box from a GeoJSON geometry, STAC Item, or FeatureCollection

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@gadomski gadomski self-requested a review June 13, 2022 20:38
@gadomski gadomski linked an issue Jun 15, 2022 that may be closed by this pull request
@gadomski
Copy link
Member

@pjhartzell can you take a look and see if there's any other geometry helpers that you think could fit into this PR?

@gadomski gadomski requested a review from pjhartzell June 15, 2022 14:38
@pjhartzell
Copy link
Collaborator

I don't have any ideas on new helpers (I assume the new footprint functionality will make its way in here) . But a comment that we have antimeridian.py, which deals exclusively with geometries. And reproject_geom in projection.py.

Off-topic: Note that reproject_geom suffers from the problem that reprojecting a geometry generally reduces its fidelity (between vertices) to the originally described shape. Closely related to one of the challenges in the upcoming footprint creator.

@gadomski
Copy link
Member

Off-topic: Note that reproject_geom suffers from the problem that reprojecting a geometry generally reduces its fidelity (between vertices) to the originally described shape. Closely related to one of the challenges in the upcoming footprint creator.

@pjhartzell worth opening its own issue for?

@pjhartzell
Copy link
Collaborator

@gadomski I can open one up.

geomatician and others added 3 commits June 21, 2022 15:02
@gadomski gadomski merged commit a885f76 into stac-utils:main Jun 22, 2022
@geomatician geomatician deleted the helper branch June 24, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add common geometry helpers to core
4 participants