Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that shapely be >=2.0.0 and unify reproject_* #441

Merged
merged 10 commits into from
Jun 28, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 23, 2023

Description:
I ran into this while working on #440 and then noticed it again when I started on #362. Seems like a nice simplification.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@jsignell jsignell requested a review from gadomski as a code owner June 23, 2023 19:31
@jsignell
Copy link
Member Author

Just a note that I was wondering why the minimum tests were just starting to say that they were failing and I think it's because some tests were getting skipped because the env wasn't resolving properly. See this job on main: https://github.com/stac-utils/stactools/actions/runs/5358201926/jobs/9720151038#step:5:46

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/stactools/core/create.py Outdated Show resolved Hide resolved
src/stactools/core/projection.py Show resolved Hide resolved
jsignell and others added 3 commits June 26, 2023 14:24
@jsignell jsignell self-assigned this Jun 27, 2023
@jsignell jsignell requested a review from gadomski June 27, 2023 14:36
Don't know why
@gadomski gadomski added this to the 0.5.0 milestone Jun 28, 2023
@jsignell jsignell enabled auto-merge (squash) June 28, 2023 12:12
@jsignell jsignell disabled auto-merge June 28, 2023 19:01
@jsignell jsignell enabled auto-merge (squash) June 28, 2023 22:10
@jsignell jsignell merged commit f68bd60 into stac-utils:main Jun 28, 2023
@gadomski gadomski mentioned this pull request Aug 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants