Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make stats and histogram optional #466 #467

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

thomas-maschler
Copy link
Contributor

Before you submit a pull request, please fill in the following:

Related Issue(s):
#466

Description:
add kwargs statistics and histogram to core.add_raster_to_item.
add tests

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@gadomski gadomski self-requested a review September 29, 2023 19:22
tests/core/test_add_raster.py Outdated Show resolved Hide resolved
tests/core/test_add_raster.py Outdated Show resolved Hide resolved
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the extensive tests 👍🏼. For your awareness, it can be slightly nicer to open the PR from a feature branch on your fork (e.g. optional-stats-and-hist) instead of PR-ing directly from main. Not a huge issues for something like this, but generally can be better practice since you might need to uptake new changes to upstream main at some point.

@gadomski gadomski enabled auto-merge (squash) October 2, 2023 14:55
@gadomski gadomski merged commit 149f3c8 into stac-utils:main Oct 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants