Make stac-validator and stac-check optional #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsignell
reviewed
Nov 17, 2023
| if HAS_STAC_VALIDATOR: | ||
| from stactools.cli.commands import validate | ||
|
|
||
| registry.register_subcommand(validate.create_validate_command) |
There was a problem hiding this comment.
I guess my only question is what happens if a user tries to run stac validate and they don't have the deps? Ideally that would result in a nice error message that tells them what to do. So maybe that would lend itself to always registering and then have the error raised within the actual call to do validation?
There was a problem hiding this comment.
Hm, that's a good point. I can make a follow-on that makes the UX a bit nicer.
There was a problem hiding this comment.
I see people writing import_optional helpers a lot. Ala https://github.com/stac-utils/xpystac/blob/main/xpystac/utils.py#L5-L10
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
They have some unnecessary required dependencies that pollute downstreams. cc @pjhartzell @jkeifer
PR checklist:
scripts/format).scripts/lint).scripts/test).