Fix the --enable-proj flag for landsat's convert command
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 84.89% 84.89%
=======================================
Files 81 81
Lines 2463 2463
=======================================
Hits 2091 2091
Misses 372 372
Continue to review full report at Codecov.
|
This was breaking click's option handling, making the `--enable-proj` flag not work.
--enable-proj is tested elsewhere, and this was breaking the convert test because the USGS files required to set the projection information are behind a web login.
lossyrob
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #91, I discovered that the
landsat convert --enable-projflag was not working. This PR adds an initially-failing test and a fix.I implemented this fix to keep as much existing behavior as possible, namely keeping the
--enable-projas a flag. However, the more click-y way of doing this would be to switch to a--proj/--no-projflag. If the reviewer thinks that--proj/--no-projwould be better, it wouldn't be hard to do that instead, but it would require changing a couple more tests (and possibly downstream users' cli arguments).