Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark on getFrameClassicalAcceleration #2169

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Fix stub generation ([#2166](https://github.com/stack-of-tasks/pinocchio/pull/2166))

### Added
- Add `examples/floating-base-velocity-viewer.py` to visualize floating base velocity [#2143](https://github.com/stack-of-tasks/pinocchio/pull/2143)
- Add `examples/floating-base-velocity-viewer.py` to visualize floating base velocity ([#2143](https://github.com/stack-of-tasks/pinocchio/pull/2143))
- Add remark to the documentation of `getFrame(Classical)Acceleration` functions ([#2169](https://github.com/stack-of-tasks/pinocchio/pull/2169))

## [2.7.0] - 2024-01-23

Expand Down
19 changes: 16 additions & 3 deletions include/pinocchio/algorithm/frames.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ namespace pinocchio

/**
* @brief Returns the spatial acceleration of the Frame expressed in the desired reference frame.
* You must first call pinocchio::forwardKinematics to update placement, velocity and acceleration values in data structure.
* You must first call pinocchio::forwardKinematics to update placement, velocity and acceleration values in the data structure.
*
* @param[in] model The kinematic model
* @param[in] data Data associated to model
Expand All @@ -111,7 +111,13 @@ namespace pinocchio
*
* @return The spatial acceleration of the Frame expressed in the desired reference frame.
*
* @warning Second order forwardKinematics should have been called first
* @warning Second order @ref forwardKinematics should have been called first
*
* @remark In the context of a frame placement constraint \f$J(q) a + \dot{J}(q, v) v = 0\f$,
* one way to compute the second term \f$\dot{J}(q, v) v\f$ is to call second-order @ref forwardKinematics with a zero acceleration,
* then read the remaining \f$\dot{J}(q, v) v\f$ by calling this function.
* This is significantly more efficient than applying the matrix \f$\dot{J}(q, v)\f$ (from @ref getFrameJacobianTimeVariation)
* to the velocity vector \f$v\f$.
*/
template<typename Scalar, int Options, template<typename,int> class JointCollectionTpl>
inline MotionTpl<Scalar, Options>
Expand All @@ -132,7 +138,14 @@ namespace pinocchio
*
* @return The classical acceleration of the Frame expressed in the desired reference frame.
*
* @warning Second order forwardKinematics should have been called first
* @warning Second order @ref forwardKinematics should have been called first
*
* @remark In the context of a frame placement constraint \f$J(q) a + \dot{J}(q, v) v = 0\f$,
* one way to compute the second term \f$\dot{J}(q, v) v\f$ is to call second-order @ref forwardKinematics with a zero acceleration,
* then read the remaining \f$\dot{J}(q, v) v\f$ by calling this function.
* This is significantly more efficient than applying the matrix \f$\dot{J}(q, v)\f$ (from @ref getFrameJacobianTimeVariation)
* to the velocity vector \f$v\f$.
*
*/
template<typename Scalar, int Options, template<typename,int> class JointCollectionTpl>
inline MotionTpl<Scalar, Options>
Expand Down
Loading