Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Feature: Improve GHA workflow #13

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Feature: Improve GHA workflow #13

merged 1 commit into from
Aug 26, 2022

Conversation

matheusferreirazup
Copy link
Contributor

@matheusferreirazup matheusferreirazup commented Aug 26, 2022

Signed-off-by: Matheus Ferreira matheus.ferreira@zup.com.br

Checklist Reviewer

  • Check if the pull request references the link (url) of the ISSUE or TASK related to the implementation.

  • Make sure the pull request has a clear description of what was implemented, with gifs (using terminalizer) if possible.

  • Check if the pull request has an appropriate label for the state it is in (WIP, ready-for-review, bug, etc...).

  • Check if the pull request needs a walkthrough for reviewers to test the implementation.

  • Check if the code present in the pull request has been tested (unit and integrated tests) if necessary.

  • Check that the pull request was opened against the correct branch (main for fix, release-x.y.x for new features or improvements).


Issue Description

  • Improve GHA workflows
    • Add secrets
  • Add --slient to curl

Signed-off-by: Matheus Ferreira <matheus.ferreira@zup.com.br>
@matheusferreirazup matheusferreirazup added enhancement New feature or request changes Code changes labels Aug 26, 2022
Copy link
Contributor

@adroaldonetozup adroaldonetozup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adroaldonetozup adroaldonetozup merged commit 733c422 into main Aug 26, 2022
@adroaldonetozup adroaldonetozup deleted the feature/workflows branch August 26, 2022 14:59
adroaldonetozup pushed a commit that referenced this pull request Sep 22, 2022
Signed-off-by: Matheus Ferreira <matheus.ferreira@zup.com.br>

Signed-off-by: Matheus Ferreira <matheus.ferreira@zup.com.br>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changes Code changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants