fix: make PURLs use oci type / fixed SBOM component name #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dervoeti
force-pushed
the
fix/oci-purls
branch
from
647a887
to
9f8c03d
Compare
dervoeti
changed the title
Techassi
previously requested changes
Oct 21, 2024
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing as stackabletech/operator-templating#448, but for our product images. It probably makes sense for the same person to review both this PR and the other.
Use OCI type for PURLs, according to https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#oci
This is more correct in general and most importantly makes the PURL equal to the one Trivy generates for our container images.
This PR is a bit more complicated than the one for operators, since I had to extract the product name (e.g. "kafka") and the architecture before generating the PURL.
I also added another small change to this PR:
The
--source-namepassed to Syft is now just the name of the image. Currently, it would besdp/kafka. This change changes it to justkafka. The parameter ist reflected in.metadata.component.namein the SBOM and I think justkafkais the correct value here, it should not include the repository.