Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nifi): Activate "include-hadoop" profile for nifi 2.* #958

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Dec 16, 2024

Description

Since NiFi 2.0.0 PutIceberg Processor and services were removed, so including the include-iceberg profile does nothing. Additionally some modules were moved to optional build profiles, so we need to add include-hadoop to get nifi-parquet-nar for example.

This PR adds profiles depending on the NiFi version.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

Preview Give feedback
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@xeniape xeniape self-assigned this Dec 16, 2024
nifi/Dockerfile Outdated Show resolved Hide resolved
@sbernauer sbernauer changed the title fix: activate include-hadoop profile for nifi 2.* fix(nifi): activate include-hadoop profile for nifi 2.* Dec 17, 2024
@sbernauer sbernauer changed the title fix(nifi): activate include-hadoop profile for nifi 2.* fix(nifi): Activate "include-hadoop" profile for nifi 2.* Dec 17, 2024
@xeniape xeniape requested a review from sbernauer December 18, 2024 11:34
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xeniape xeniape added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 77a6239 Dec 18, 2024
3 checks passed
@xeniape xeniape deleted the fix/add-parquet-nar-to-nifi branch December 18, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants