Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support setting TLS certificate lifetimes #660

Merged
merged 17 commits into from
Dec 4, 2024
Merged

feat: Support setting TLS certificate lifetimes #660

merged 17 commits into from
Dec 4, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented Nov 28, 2024 •
edited
Loading

Description

Part of: stackabletech/issues#586

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@razvan razvan mentioned this pull request Nov 28, 2024
Closed
@razvan razvan requested a review from a team November 28, 2024 12:02
@sbernauer
Copy link
Member

sbernauer commented Nov 29, 2024 •
edited
Loading

Just for the record: I reviewed stackabletech/hbase-operator#598, the comments also apply here

@razvan razvan changed the title feat: requestedSecretLifetime role group property added feat: Support setting TLS certificate lifetimes Nov 29, 2024
@razvan razvan self-assigned this Dec 2, 2024
@sbernauer
Copy link
Member

Just for the record for others: I'd say stackabletech/hbase-operator#598 is the template - which is currently under review. Please place your feedback there

sbernauer
sbernauer requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits

CHANGELOG.md Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
rust/crd/src/security.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/druid_controller.rs Outdated Show resolved Hide resolved
rust/crd/src/security.rs Outdated Show resolved Hide resolved
razvan and others added 10 commits December 4, 2024 10:25
@razvan @sbernauer
Update CHANGELOG.md
1b568a6 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/crd/src/lib.rs
3cadcd6 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/crd/src/lib.rs
7fd415c 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/crd/src/lib.rs
61a877b 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/crd/src/lib.rs
bca44a1 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/crd/src/lib.rs
be23623 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/crd/src/security.rs
82ed552 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/operator-binary/src/druid_controller.rs
b3933f3 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/crd/src/security.rs
d2518b7 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan
Merge branch 'main' into feat/issue-586
a9cc1eb
sbernauer
sbernauer approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's hope it compiles ^^

@razvan razvan enabled auto-merge December 4, 2024 09:33
github-actions[bot]
github-actions bot reviewed Dec 4, 2024
View reviewed changes
rust/crd/src/security.rs Outdated Show resolved Hide resolved
@sbernauer sbernauer disabled auto-merge December 4, 2024 09:38
@razvan razvan added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit e78f633 Dec 4, 2024
17 checks passed
@razvan razvan deleted the feat/issue-586 branch December 4, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sbernauer sbernauer sbernauer approved these changes

Assignees

@razvan razvan

Labels
release/2025-03
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvan @sbernauer @lfrancke