Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run containerdebug in the background #605

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Conversation

razvan
Copy link
Member

@razvan razvan commented Dec 9, 2024

Description

Part of: stackabletech/issues#527

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@razvan razvan self-assigned this Dec 9, 2024
@razvan razvan requested a review from a team December 9, 2024 15:16
@razvan razvan requested review from nightkr and removed request for a team December 10, 2024 13:42
@nightkr
Copy link
Member

nightkr commented Dec 10, 2024

Looks like the smoke tests now fails on step 60 (phoenix) because the restserver gets OOMKilled and then doesn't have the /tmp/test_phoenix.sh script anymore. After increasing the restserver memory budget to 1GiB it still seems to fail for some unclear reason, but only when running without --skip-delete.

@razvan
Copy link
Member Author

razvan commented Dec 12, 2024

@nightkr
Copy link
Member

nightkr commented Dec 19, 2024

Tests pass for me if I up the resource limits:

diff --git a/tests/templates/kuttl/kerberos/30-install-hbase.yaml.j2 b/tests/templates/kuttl/kerberos/30-install-hbase.yaml.j2
index f862651..31a27a6 100644
--- a/tests/templates/kuttl/kerberos/30-install-hbase.yaml.j2
+++ b/tests/templates/kuttl/kerberos/30-install-hbase.yaml.j2
@@ -39,6 +39,9 @@ commands:
           config:
             logging:
               enableVectorAgent: {{ lookup('env', 'VECTOR_AGGREGATOR') | length > 0 }}
+            resources:
+              memory:
+                limit: 1536Mi
           roleGroups:
             default:
               replicas: 2
diff --git a/tests/templates/kuttl/smoke/30-install-hbase.yaml.j2 b/tests/templates/kuttl/smoke/30-install-hbase.yaml.j2
index ac1bed8..53e9a98 100644
--- a/tests/templates/kuttl/smoke/30-install-hbase.yaml.j2
+++ b/tests/templates/kuttl/smoke/30-install-hbase.yaml.j2
@@ -45,6 +45,9 @@ spec:
     config:
       logging:
         enableVectorAgent: {{ lookup('env', 'VECTOR_AGGREGATOR') | length > 0 }}
+      resources:
+        memory:
+          limit: 1Gi
     roleGroups:
       default:
         configOverrides:

But that's pretty concerning to me, is that indicative of a larger problem with our default resource limits here?

@razvan
Copy link
Member Author

razvan commented Dec 19, 2024

Thanks, applied.

@razvan razvan added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 99effb0 Dec 19, 2024
17 checks passed
@razvan razvan deleted the feature/containerdebug branch December 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants