Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't default roleGroup replicas to zero when not specified #402

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix: Don't default roleGroup replicas to zero when not specified #402

merged 3 commits into from
Oct 5, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 29, 2023 •
edited by lfrancke
Loading

Description

Fixes #398
Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer self-assigned this Sep 29, 2023
fhennig
fhennig reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what about an integration test for this? Might be a bit trivial but still 😬

Also, we should document the behaviour if the replicas are omitted.

@sbernauer
Copy link
Member Author

You might be interested in stackabletech/documentation#461 :)
Regarding the integration test I see why we want it, but I think it this should be a unit test but well... we have problems with mocking k8s

fhennig
fhennig previously approved these changes Oct 5, 2023
View reviewed changes
@sbernauer sbernauer enabled auto-merge October 5, 2023 13:38
maltesander
maltesander approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit cca1dc8 Oct 5, 2023
28 of 29 checks passed
@sbernauer sbernauer deleted the fix/null-replicas branch October 5, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

@fhennig fhennig fhennig left review comments

Assignees

@sbernauer sbernauer

Labels
release/2023-11 type/bug
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't default roleGroup replicas to zero when not specified
4 participants
@sbernauer @fhennig @maltesander @lfrancke