Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test utility containers with tini #633

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Run test utility containers with tini #633

merged 1 commit into from
Dec 17, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Dec 17, 2024

Description

This should help speed up test teardown, since they handle SIGTERM instead of having to wait for the container shutdown to timeout.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

This should help speed up test teardown, since they handle SIGTERM
instead of having to wait for the container shutdown to timeout.
@nightkr nightkr requested a review from a team December 17, 2024 15:27
@razvan
Copy link
Member

razvan commented Dec 17, 2024

I don't see where tini is used.

@nightkr
Copy link
Member Author

nightkr commented Dec 17, 2024

It's managed by the shareProcessNamespace flag.

@nightkr nightkr added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 5e6e339 Dec 17, 2024
16 of 17 checks passed
@nightkr nightkr deleted the bugfix/test-tini branch December 17, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants