Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate NodePort address listings from PersistentVolume reservations #231

Merged
merged 11 commits into from
Oct 7, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 4, 2024

Description

Fixes #220, fixes #229.

This should make stable address listings.. stabler, since the PV "represents" the lifetime of the reservation.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@nightkr nightkr requested review from sbernauer and a team October 7, 2024 11:50
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor style comments

rust/operator-binary/Cargo.toml Outdated Show resolved Hide resolved
rust/operator-binary/src/listener_controller.rs Outdated Show resolved Hide resolved
@nightkr nightkr requested a review from sbernauer October 7, 2024 13:48
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nightkr nightkr added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit b01da45 Oct 7, 2024
31 checks passed
@nightkr nightkr deleted the feature/sticky-nodeport-addresses branch October 7, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants