Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set PR-suffix on PRs against non-main/release branches #471

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 5, 2024

See stackabletech/stackable-utils#95 (files)

This PR:

  • ensures that PRs against non-main (release) branches also incorporate the PR-number into the image name, so that images from a not-yet-merged release-candidate PR have a name distinct from the merged result
  • e.g. 24.11.1-rc1-pr554 (unmerged PR branch) vs. 24.11.1-rc1 (merged and tagged in the rlease branch)

@adwk67 adwk67 marked this pull request as ready for review December 6, 2024 08:43
@adwk67 adwk67 requested a review from a team December 6, 2024 08:43
@adwk67 adwk67 self-assigned this Dec 6, 2024
Techassi
Techassi previously approved these changes Dec 6, 2024
@NickLarsenNZ NickLarsenNZ self-requested a review December 6, 2024 09:20
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67
Copy link
Member Author

adwk67 commented Dec 6, 2024

@NickLarsenNZ Thanks for the suggestions: I've committed them, so we have an example of how to do it properly until such time as the workflows are refactored.

@adwk67 adwk67 requested a review from Techassi December 6, 2024 09:58
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 2b806e1 Dec 6, 2024
2 checks passed
@adwk67 adwk67 deleted the ci/rc-pr-images branch December 6, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants