Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nix Shell support #296

Merged
merged 4 commits into from
May 28, 2024
Merged

feat: Nix Shell support #296

merged 4 commits into from
May 28, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented May 28, 2024

Description

  • Add nix-shell support
    • Removed superfluous copy/paste stuff from default.nix, and rearranged it to work more like the operators.
  • Update niv dependencies (niv update)
  • Update nix cargo dependencies (make regenerate-nix)
  • Update OpenAPI Typescript schema

Important

Should we add niv update to the regenerate-nix Make target?
Also, should we add these nix dependency updates to the pre-commit hooks?

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Reviewer

Acceptance

@NickLarsenNZ NickLarsenNZ self-assigned this May 28, 2024
@sbernauer sbernauer self-requested a review May 28, 2024 06:55
@sbernauer
Copy link
Member

This works perfectly fine, many thanks! (also tested make run-dev)

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 85c9b52 May 28, 2024
4 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/nix-shell branch May 28, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants