-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ctl): Namespace separation and support skipping release installation #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested it yet, waiting for non-draft PR with that
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had the time to actually use and test it yet :/
The final missing pice from stackabletech/stackablectl#259 would be
Demos have the possibility to say "i can only run in stackable-demo" namespace (in stacks.yaml or demo.yaml). If they do so, a warning is printed when they are installed in a different namespace, saying the demo will likely not work. This can be the case as we have to use FQDN service names so that the TLS certs are valid
We could do it in a follow-up PR but I think it should not be that complicated
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo r -p stackablectl -- stack in trino-superset-s3 -c kind
Finished dev [unoptimized + debuginfo] target(s) in 0.10s
Running `target/debug/stackablectl stack in trino-superset-s3 -c kind`
Error: stack command error
Caused by these errors (recent errors listed first):
1: stack error
2: release install error *
3: failed with Helm error *
4: failed to install Helm release *
5: helm error: create: failed to create: namespaces "stackable-operators" not found
NOTE: Some redundant information has been removed from the lines marked with *. Set SNAFU_RAW_ERROR_MESSAGES=1 to disable this behavior.
Change LGTM, did play around and bit and gave feedback via PN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whup whup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing missing from stackabletech/stackablectl#259 is:
stackablectl tries to create specified namespaces if not existing
- If this fails because of missing permissions an error is thrown as the user is suggested to specify operators and demo namespace manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Fixes stackabletech/stackablectl#259
Needs stackabletech/stackablectl#274