Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named targetPort for cockpitd service #81

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 4, 2023

Description

Followup to #80.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from sbernauer August 4, 2023 12:41
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh we did try containerPort: http and did not get it to work. Thx!

@nightkr nightkr added this pull request to the merge queue Aug 4, 2023
Merged via the queue into main with commit affea9b Aug 4, 2023
25 checks passed
@nightkr nightkr deleted the nightkr-patch-1 branch August 4, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants